Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test cases for serverExec #200

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Add test cases for serverExec #200

merged 2 commits into from
Mar 1, 2024

Conversation

ushabelgur
Copy link
Contributor

Proposed Changes

  • add test for validating http request with a not expected method fails
  • add test for validating that a token can't be used twice
  • add test to validate a request with a valid token and a not existing machine fails

Fixes #90

@ushabelgur ushabelgur added integration-tests to run integration tests and removed size/L labels Feb 22, 2024
@github-actions github-actions bot added enhancement New feature or request server labels Feb 22, 2024
@ushabelgur ushabelgur marked this pull request as ready for review February 22, 2024 12:28
@ushabelgur ushabelgur requested a review from a team as a code owner February 22, 2024 12:28
lukas016
lukas016 requested changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@lukas016 lukas016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

machine isn't deleted, when test fail

hardikdr
hardikdr reviewed Feb 28, 2024
View reviewed changes
Copy link
Member

@hardikdr hardikdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @ushabelgur .

Can you please inform here when the requested changes has already been taken care of.

@ushabelgur
Copy link
Contributor Author

@hardikdr Machine deletion part at the end of test case has been addressed. But the test case to validate whole streaming logic with send command and read output, I am still working on it.

@ushabelgur ushabelgur mentioned this pull request Feb 29, 2024
Open
lukas016
lukas016 previously approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@lukas016 lukas016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests will improve in follow up issue: #207

lukas016
lukas016 approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@lukas016 lukas016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hardikdr
hardikdr approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@hardikdr hardikdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @ushabelgur, appreciate it.

@hardikdr hardikdr merged commit f65182b into main Mar 1, 2024
9 checks passed
@hardikdr hardikdr deleted the enh/server-exec-test branch March 1, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukas016 lukas016 lukas016 approved these changes

@hardikdr hardikdr hardikdr approved these changes

Assignees

@ushabelgur ushabelgur

Labels
enhancement New feature or request integration-tests to run integration tests server size/L
Projects
Compute
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide tests for ServeExec
3 participants
@ushabelgur @hardikdr @lukas016